misc: mark Body::channel() as deprecated in 0.14
#3823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: katelyn martin <[email protected]>
|
with hyperium/http-body#140 landed, there's now a much cleaner path for migration. calls to now that there is a more direct 1:1 equivalent for those migrating to use, i think this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit marks
Body::channel()as deprecated in the 0.14 release.#2970 (see #2962) made this interface private, and hyper 1.0 no longer includes this function. instead, users should wrap an
mpsc::Receiver<T>in aStreamBody. this should help users migrating from hyper 0.14 to 1.0, by indicating that this interface is affected by the breaking changes in hyper 1.0, and indicating a suitable upgrade path.